events: change status of event.srcElement to legacy#46085
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 7, 2023
Merged
events: change status of event.srcElement to legacy#46085nodejs-github-bot merged 1 commit intonodejs:mainfrom
event.srcElement to legacy#46085nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
deokjinkim
force-pushed
the
230104_event_remove_srcelement
branch
from
28415d3 to
1b33fbc
Compare
deokjinkim
changed the title
srcElement from Eventevent.srcElement
Contributor
Author
|
@RaisinTen Thank you for kind explanation. Applied doc-deprecation instead of delete. |
RaisinTen
added
doc
Member
|
@deokjinkim could you also update the PR description? It still says that srcElement is being removed. |
Contributor
|
Probably |
deokjinkim
force-pushed
the
230104_event_remove_srcelement
branch
from
1b33fbc to
4f8963d
Compare
Contributor
Author
Updated the PR description. Thank you for guide. |
benjamingr
requested changes
Jan 6, 2023
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
event.srcElement is a legacy feature (according to the spec).
It's just a filler for spec compliance in Node.js since we don't have any event targets that do event propagation.
I seriously doubt that it'd ever be removed so I don't think we should deprecate it which implies removal until the spec does.
Member
|
(That said, thank you for working on this!) |
aduh95
reviewed
Jan 6, 2023
deokjinkim
force-pushed
the
230104_event_remove_srcelement
branch
from
17494ff to
b933185
Compare
deokjinkim
changed the title
event.srcElementevent.srcElement to legacy
`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event
deokjinkim
force-pushed
the
230104_event_remove_srcelement
branch
from
b933185 to
834c2b3
Compare
aduh95
approved these changes
Jan 7, 2023
aduh95
added
eventtarget
benjamingr
approved these changes
Jan 7, 2023
aduh95
added
the
author ready
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 513c151 |
RafaelGSS
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Jan 17, 2023
`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: nodejs#46085 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 20, 2023
`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #46085 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #46085 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
`event.srcElement` is described as legacy in spec. Refs: https://dom.spec.whatwg.org/#interface-event PR-URL: #46085 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event.srcElementis described as legacy in spec.Refs: https://dom.spec.whatwg.org/#interface-event